-
-
Notifications
You must be signed in to change notification settings - Fork 58
Test Spanish (es) locale support #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Configure netlify.toml to enable all locales for l10n* branches - Add Spanish (es) to default-settings.js for testing - Update L10N.md with new locale testing workflow
✅ Deploy Preview for pauseai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Use specific branch context (wildcards not supported by Netlify) - Set PARAGLIDE_LOCALES to 'es' for faster, focused testing - Update docs to clarify testing branches aren't merged directly
Environment Variable Fix AppliedJust merged a fix from main that addresses the TRANSLATION_OPENROUTER_API_KEY vs L10N_OPENROUTER_API_KEY inconsistency we discovered. The Issue
The Fix (commit fd6eac2)
Next StepsAfter this deploys successfully, we can remove The latest build should now use the correct env var consistently. |
The logo link was hardcoded to '/' which meant Spanish users on /es/ pages
would be taken back to the English homepage when clicking the logo.
Now uses localizeHref('/') to properly localize the link, so Spanish users
stay in /es/ when clicking the logo.
Fixes part of the issues described in #448
|
borja left a comment: Hi Anthony, Borja Here. I have a few comments from the Spain group Browser metadata |
|
Hi team, Recently i joined the spanish working group and said i would try to be on top of this. Our current standpoint is quality is good enough for this to reach production and we assume we can keep iterating on top of it. Spanish communities in our view tend not to have a fair english level so we believe releasing this version of the spanish translations would help a great deal. Thanks in advance! The issues we could spot doing a review are
|
|
Thanks. I thought I'd set things up to tell me when these issues were opened but apparently not. Until I fix that by all means @anthonybailey or assign me. |
|
The general case of "this special page lacks translations" basically maps to the page not by being a slugged "post", but rather through special case +page.ts and +server.ts wrappers. Thanks for calling out particular prominent ones. The website homepage is one special case but some effort has been made there - spot any problems there? Dynamic pages are harder to l10n than static ones in the current system. I will look out for general patterns to help while working on individual cases. |
Nope, homepage looks spot on |
|
Ok, so all problems reported are either "this special page is still English" or "l10ns broke my link". Serious problems, of course. Any specific places where you would go "this word is a bad choice" or "in general, the tone is wrong" or "see, in Spain, I'd have expected a different kind of 'you' when the site addresses the reader" etc? |
yup, pretty much these issues
We had someone review the site and no "wrong choice of word or tone" was spotted. There is a comment regarding inconsistent "kind of you" but not a particular example was given and I cannot spot it myself. To my eyes the content is using (at least mostly) the right "kind of you". |
|
That's reassuring. This is only using Llama currently so seems certain auto-translation can be as great as we need. Once I've got collage work PauseAI/pauseai-collagen#1 out the way I'll move back to this. |
|
Joining dots... This remains in draft. So you should see changes in the Git repos but only on the branch best I know. We are looking to fix issues and productionize in some way. We are happy to publish current l10n to es to those readers, once links are fixed and special case pages remaining in English are acknowledged to be in that state when es readers see them. There are two directions here with with overlap. Doing it on the main website with suitable workarounds for lack of prefix-all-locales redirection and associated 500 responses is best. As an intermediate informing the same work serving static copies of fixed pages from PauseAI.es is planned. @danilupion has most focus on this. #515 is part of that work but I understand it went slightly awry. |

Testing the new l10n branch workflow for Spanish translations.
This PR:
The Netlify preview should show Spanish translations at /es paths.
This is a draft PR for testing only - not intended for merge to main.